Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill in full design explanation in README.md #35

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

MendyBerger
Copy link
Collaborator

No description provided.

@MendyBerger MendyBerger requested a review from seanisom October 16, 2024 17:02
Copy link
Collaborator

@seanisom seanisom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@@ -47,17 +47,52 @@ This proposal is a collection of multiple packages.

### Goals [or Motivating Use Cases, or Scenarios]

[What is the end-user need which this project aims to address?]
- Bring some of the benefits that Wasm provides to CPU code, over to GPU code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to clarify this - we're not explicitly addressing GPU ISAs which this statement could imply

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, feel free to edit the text


`wasi:webgpu` is based on the official [webgpu spec](https://www.w3.org/TR/webgpu/).

`wasi:webgpu` does deviate sometimes from the webgpu spec, namely, in cases where the spec makes assumptions about running in a web or JS environment. Wherever `wasi:webgpu` deviates from the spec, a clear explanation should be documented.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should say it deviates, but we should be careful to clarify that it varies only in syntax and not semantics. The goal is to remain 100% compatible with the functionality of WebGPU, with just minor syntactical differences from not having a JS/Web env.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, feel free to edit the text

README.md Show resolved Hide resolved
@seanisom seanisom merged commit 3dbff79 into main Oct 30, 2024
1 check passed
@MendyBerger MendyBerger deleted the MendyBerger-patch-5 branch October 30, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants