Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add V8 testing on CI #7208

Merged
merged 17 commits into from
Jan 17, 2025
Merged

Add V8 testing on CI #7208

merged 17 commits into from
Jan 17, 2025

Conversation

kripken
Copy link
Member

@kripken kripken commented Jan 11, 2025

This adds v8 from jsvu to CI, and a single lit test that uses it.

Later PRs will use d8 to test more complex things (in particular,
things like JSPI that need a recent d8, and not older node).

@kripken kripken marked this pull request as ready for review January 16, 2025 20:39
@kripken kripken requested a review from tlively January 16, 2025 20:39
@kripken
Copy link
Member Author

kripken commented Jan 17, 2025

Apparently jsvu is not compatible with alpine - the binaries it provides are not compatible with that linux distro/arch. I think I just need to skip the test there.

@tlively I can't figure out how to do that. The llvm docs for lit do mention --xfail and the env var LIT_XFAIL, but the lit we use, installed by python, does not actually support --xfail, and it seems to ignore the env var as well. I guess it is a limited version of the real one? (In llvm-lit I do see --xfail exists.)

Is there some other way to skip tests in lit? It seems like we might never have done so before in binaryen?

@kripken
Copy link
Member Author

kripken commented Jan 17, 2025

I found no better workaround for skipping these tests on alpine than to just delete them. If we can find a better workaround, we can apply that later.

@kripken kripken merged commit e984c89 into WebAssembly:main Jan 17, 2025
13 checks passed
@kripken kripken deleted the d8.test branch January 17, 2025 23:36
@tlively
Copy link
Member

tlively commented Jan 18, 2025

The lit we use should be a repacked version of the original llvm lit, so I would have expected it to support all the same features. (Our filecheck is a simplified Python port of the original filecheck, though.)

I can try to investigate xfail next week. You’re right that it’s not something we’ve had to use yet in Binaryen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants