-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add V8 testing on CI #7208
Add V8 testing on CI #7208
Conversation
Apparently jsvu is not compatible with alpine - the binaries it provides are not compatible with that linux distro/arch. I think I just need to skip the test there. @tlively I can't figure out how to do that. The llvm docs for lit do mention Is there some other way to skip tests in lit? It seems like we might never have done so before in binaryen? |
I found no better workaround for skipping these tests on alpine than to just delete them. If we can find a better workaround, we can apply that later. |
The lit we use should be a repacked version of the original llvm lit, so I would have expected it to support all the same features. (Our filecheck is a simplified Python port of the original filecheck, though.) I can try to investigate xfail next week. You’re right that it’s not something we’ve had to use yet in Binaryen. |
This adds v8 from jsvu to CI, and a single lit test that uses it.
Later PRs will use d8 to test more complex things (in particular,
things like JSPI that need a recent d8, and not older node).