Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow specifying the external memory #7125

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
+147 −2
Open

allow specifying the external memory #7125

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
75a7f5d
allow specifying the external memory
gkgoat1 Nov 27, 2024
61c68ff
apply suggestions
gkgoat1 Nov 27, 2024
6ab2142
add test
gkgoat1 Nov 28, 2024
bbfb574
Apply suggestions from code review
gkgoat1 Dec 5, 2024
179944a
update test
gkgoat1 Dec 5, 2024
f02138f
Apply suggestions from code review: style and further tests
gkgoat1 Dec 23, 2024
40f1ad1
apply more suggestions from code review
gkgoat1 Dec 23, 2024
64faf28
fix build
gkgoat1 Dec 30, 2024
58e76f0
fix the test
gkgoat1 Dec 30, 2024
8eb339e
Add a memory to the local test so Asyncify can use it (even though it…
gkgoat1 Jan 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/passes/Asyncify.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1648,14 +1648,26 @@ struct Asyncify : public Pass {
auto propagateAddList = hasArgument("asyncify-propagate-addlist");

// Ensure there is a memory, as we need it.

if (secondaryMemory) {
auto secondaryMemorySizeString =
getArgumentOrDefault("asyncify-secondary-memory-size", "1");
Address secondaryMemorySize = std::stoi(secondaryMemorySizeString);
asyncifyMemory = createSecondaryMemory(module, secondaryMemorySize);
} else {
MemoryUtils::ensureExists(module);
asyncifyMemory = module->memories[0]->name;
if (module->memories.size() == 1) {
MemoryUtils::ensureExists(module);
asyncifyMemory = module->memories[0]->name;
} else {
auto asyncifyMemoryValue =
getArgumentOrDefault("asyncify-memory", "memory");
for (auto& export : module->exports) {
if (export->kind == ExternalKind::Memory &&
export->name == asyncifyMemoryValue) {
asyncifyMemory = export->value;
gkgoat1 marked this conversation as resolved.
Show resolved Hide resolved
}
}
gkgoat1 marked this conversation as resolved.
Show resolved Hide resolved
}
}
pointerType =
module->getMemory(asyncifyMemory)->is64() ? Type::i64 : Type::i32;
Expand Down