Don't strip target features in wasm-emscripten-finalize (#7043)

This makes the behavior consistent with emcc builds where we don't run finalization, and potentially makes testing and debugging easier. Emscripten still strips the target features section when optimizing.
WebAssembly · Oct 30, 2024 · 39bf87e · 39bf87e
1 parent a0f77ad
commit 39bf87e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/tools/wasm-emscripten-finalize.cpp b/src/tools/wasm-emscripten-finalize.cpp
@@ -266,8 +266,6 @@ int main(int argc, const char* argv[]) {
     passRunner.add("legalize-js-interface");
   }
 
-  passRunner.add("strip-target-features");
-
   // If DWARF is unused, strip it out. This avoids us keeping it alive
   // until wasm-opt strips it later.
   if (!DWARF) {

diff --git a/test/lld/em_asm_pthread.wasm.out b/test/lld/em_asm_pthread.wasm.out
@@ -12830,4 +12830,5 @@
   )
  )
  ;; custom section "producers", size 172
+ ;; features section: threads, mutable-globals, bulk-memory, sign-ext
 )
-Original file line number
+Diff line change
@@ Expand Up / @@ -12830,4 +12830,5 @@ @@
       )
      )
      ;; custom section "producers", size 172
+     ;; features section: threads, mutable-globals, bulk-memory, sign-ext
     )