Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing indication in observations tab #26

Merged

Conversation

pantelisss
Copy link
Collaborator

Why?

Show the same error/warning indication with home screen in observations' tab

How?

  • Declared a dedicated modifier for station indication to be used in home and station screens
  • Fixed layout issue for iPad in multiple alerts view

Testing

Check a station with errors and make sure the indication is presented properly

Additional context

fixes fe-600

@pantelisss pantelisss requested a review from PavlosTze February 22, 2024 16:07
Copy link
Member

@PavlosTze PavlosTze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@pantelisss pantelisss force-pushed the feature/fe-600-missing-indication-in-observations-tab branch from ec867ee to c284e14 Compare February 27, 2024 15:53
@pantelisss pantelisss merged commit 7c38fe2 into main Feb 28, 2024
3 checks passed
@pantelisss pantelisss deleted the feature/fe-600-missing-indication-in-observations-tab branch February 28, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants