Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DeviceTypeView using jetpack compose #464

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Refactor DeviceTypeView using jetpack compose #464

merged 5 commits into from
Feb 5, 2025

Conversation

PavlosTze
Copy link
Member

Why?

Refactor DeviceTypeView using jetpack compose

How?

  • Created CardView as a reusable Card component and MediumText.
  • Then using Jetpack Compose created the layout again with it
  • Removed the old XML-related files
  • Optimized the functions in Navigator to use just one for navigating to the claiming flows.

Testing

Ensure that the UI looks the same as it is now and every card opens the correct claiming flow.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Coverage Report (Type: Instructions)

Overall Project 89.13% -0.04% ✅
Files changed 84.16% ✅

File Coverage
DevicesRewardsViewModel.kt 93.3% -3.7% ✅
NetworkStatsViewModel.kt 91.53% ✅

@PavlosTze PavlosTze force-pushed the feature/fe-1494-refactor-devicetypecardview-as-a-composable branch from 33e3f12 to 7b200ea Compare January 20, 2025 09:10
@PavlosTze
Copy link
Member Author

Won't be merged until testing is completed.

@PavlosTze PavlosTze force-pushed the feature/fe-1494-refactor-devicetypecardview-as-a-composable branch from 61812c3 to f7286ad Compare January 28, 2025 07:38
@PavlosTze
Refactor DeviceTypeView using jetpack compose
5f34a36
@PavlosTze
Refactor RetryCardView as composable
760100f
@PavlosTze
Revert "Refactor RetryCardView as composable"
c290faf 
This reverts commit ebb4826.
@PavlosTze
FE-1499 Refactor RetryCardView as composable (#468)
dcef4f4 
* Refactor RetryCardView as composable

* Feature/fe 1495 refactor headerview as a composable (#469)

* Refactor HeaderView as composable

* Enable previews in new composables

* Fix detekt

* Refactor InfoBannerCard as composable (#470)

* Refactor InfoBannerCard as composable

* Refactor RewardIssueCardView to composable. Fix ripple effect on buttons. (#472)
@PavlosTze
FE-1564 Feature/fe 1498 refactor rangeselectorview as a composable (#474
5f6e783 
)

* [WIP] Range selector view as composable

* Fix issue of charts not loading properly when API replies very fast
@PavlosTze PavlosTze force-pushed the feature/fe-1494-refactor-devicetypecardview-as-a-composable branch from f7286ad to 5f6e783 Compare February 3, 2025 11:54
@PavlosTze PavlosTze merged commit 21dc465 into main Feb 5, 2025
6 checks passed
@PavlosTze PavlosTze deleted the feature/fe-1494-refactor-devicetypecardview-as-a-composable branch February 5, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pantelisss pantelisss pantelisss approved these changes

@JohnFrontzos JohnFrontzos Awaiting requested review from JohnFrontzos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PavlosTze @pantelisss @ipanagiv