Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix curl example #80

Merged
merged 3 commits into from
Oct 26, 2018
Merged

Fix curl example #80

merged 3 commits into from
Oct 26, 2018

Conversation

arnoFleming
Copy link
Contributor

@arnoFleming arnoFleming commented Oct 19, 2018 •
edited
Loading

Update docs for readability

Proposed changes

Some curl calls weren't working. Also, some informational texts are short or almost not explanatory.

Types of changes

What types of changes does your code introduce to wt-api-docs?

  • Docs (missing or updated docs)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added necessary documentation (if appropriate)

@arnoFleming
Copy link
Contributor Author

arnoFleming commented Oct 19, 2018 •
edited
Loading

this fixes #84

@arnoFleming arnoFleming changed the title [WiP] Fix curl example Fix curl example Oct 23, 2018
@arnoFleming
Copy link
Contributor Author

arnoFleming commented Oct 25, 2018 •
edited
Loading

@arkaitzgarro , @davidenko87 feel free to comment on this one 🤓

arkaitzgarro
arkaitzgarro approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@arkaitzgarro arkaitzgarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice job 👏

bermannoah
bermannoah approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@bermannoah bermannoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good though please remember to pull from master and rebuild before merging!

@arnoFleming
Fix curl example
8b2cd49 
Update docs for readability
@arnoFleming
Copy link
Contributor Author

@bermannoah Good catch, doing it now

@bermannoah bermannoah merged commit a1ea7aa into master Oct 26, 2018
@bermannoah bermannoah deleted the fix-curl-example branch October 26, 2018 14:18
@arkaitzgarro arkaitzgarro mentioned this pull request Oct 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkaitzgarro arkaitzgarro arkaitzgarro approved these changes

@bermannoah bermannoah bermannoah approved these changes

@davidenko87 davidenko87 Awaiting requested review from davidenko87

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnoFleming @arkaitzgarro @bermannoah