Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FInput): 修复复合型输入框样式问题 #867

Merged
merged 3 commits into from
Jul 19, 2024
Merged

fix(FInput): 修复复合型输入框样式问题 #867

merged 3 commits into from
Jul 19, 2024

Conversation

zym19960704
Copy link
Collaborator

@zym19960704 zym19960704 commented Jul 17, 2024

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue (if exists):

Other information:

@@ -19,25 +19,65 @@
}

.group-append() {
.hidden-left-border();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前命名不规范,可以left统一为prepend, right统一为append
hidden-prepend-border();

.group-prepend() {
.hidden-right-border();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

命名规范

div.@{cls-prefix}-select:hover .@{cls-prefix}-select-trigger,
div.@{cls-prefix}-cascader:hover .@{cls-prefix}-select-trigger {
.border-right-pure();
}
}

.light-border {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是函数式用法,所以建议加上函数标识,虽然运行是不影响的 .light-border()

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里命名为 hover-light-border()

}
}

.hidden-right-border {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

}
}

.hidden-left-border {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

命名规范同上

}
}

.select-focus-border-light() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里命名为 focus-light-border()

@zym19960704
Copy link
Collaborator Author

zym19960704 commented Jul 19, 2024 via email

@ocean-gao ocean-gao merged commit 8547dbd into main Jul 19, 2024
1 check passed
@ocean-gao ocean-gao deleted the fix-865 branch August 9, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants