Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Table): 修复分割线样式问题 #346

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix(Table): 修复分割线样式问题 #346

merged 1 commit into from
Jul 17, 2023

Conversation

wanchun
Copy link
Collaborator

@wanchun wanchun commented Jul 17, 2023

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue (if exists):

Other information:

}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码看起来是一个CSS的代码片段。以下是一些问题和改进建议:

  1. 行号4-5的代码在修改后缺少分号,需要补充上。
  2. 行号8的代码经过拆分被放置到多行中,建议保持一致的代码风格。
  3. 行号21的选择器 ".@{table-prefix}-fixed-right.is-first" 可能存在误用的情况,需要检查语义是否正确。
  4. 行号43、53和66的选择器 ".@{table-prefix}-tr" 的相邻兄弟选择器("+")可能选择错误,需要根据实际需求确认。
  5. 行号77、87和100的选择器 ".@{table-prefix}-td, .@{table-prefix}-th" 在嵌套选择器中使用了逗号分隔,可能导致样式应用出错,需要检查逻辑是否正确。
  6. 行号115、120和133处的选择器 ".@{table-prefix}-header, .@{table-prefix}-body" 也存在嵌套选择器中使用逗号分隔的问题,需要修正。
  7. 行号127、140和145的选择器 ".@{table-prefix}-row" 中的子选择器(>)可能在逻辑上不准确,需要根据实际需求进行检查。

@winixt winixt merged commit cd6e098 into main Jul 17, 2023
2 checks passed
@winixt winixt deleted the fix-table branch July 17, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants