Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tabs属性displayDirective类型 #343

Merged
merged 1 commit into from
Jul 12, 2023
Merged

fix: tabs属性displayDirective类型 #343

merged 1 commit into from
Jul 12, 2023

Conversation

aringlai
Copy link
Collaborator

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue (if exists):

Other information:

@@ -14,7 +14,7 @@ export const tabProps = {
default: null as null,
},
displayDirective: {
type: String as PropType<'if' | 'show'>,
type: String as PropType<'if' | 'show' | 'show:lazy'>,
default: 'if',
},
} as const;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对于给定的代码补丁,这是一个简短的代码审查:

在第14行的displayDirective属性的类型声明中,新增了一个选项 'show:lazy'。这表明组件可以接受 'if''show''show:lazy' 作为有效值。这个改动似乎是可行的。

根据提供的信息,很难确定是否还有其他潜在的错误风险。要进行更全面的代码审查,可能需要查看完整的代码文件和相关的上下文。

总体而言,如果你的代码通过了所有的单元测试,并且没有其他问题,那么这个更新似乎是合理的。记得测试新功能,以确保它能按预期工作。

@wanchun wanchun merged commit 7ff006f into main Jul 12, 2023
@wanchun wanchun deleted the fix-tabs-type branch July 12, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants