Update volume calculations.

We-Gold · Aug 7, 2024 · b73063a · b73063a
1 parent 4358ebc
commit b73063a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/python/ouroboros/helpers/bounding_boxes.py b/python/ouroboros/helpers/bounding_boxes.py
@@ -246,11 +246,7 @@ def to_empty_volume(self, dtype=np.float32, num_channels=None):
         return np.zeros(shape, dtype=dtype)
 
     def calculate_volume(self):
-        return (
-            (self.x_max - self.x_min)
-            * (self.y_max - self.y_min)
-            * (self.z_max - self.z_min)
-        )
+        return np.prod(self.get_shape())
 
     def should_be_divided(self, utilized_volume):
         return utilized_volume < (1 - DEFAULT_SPLIT_THRESHOLD) * self.calculate_volume()

diff --git a/python/test/helpers/test_bounding_boxes.py b/python/test/helpers/test_bounding_boxes.py
@@ -111,7 +111,7 @@ def test_bounding_box_calculate_volume():
     rect = np.array([[0, 0, 0], [1, 1, 1]])
     bbox = BoundingBox(rect)
     volume = bbox.calculate_volume()
-    assert volume == 1
+    assert volume == 8
 
 
 def test_to_empty_volume():