Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to add cli option for launching wcm directly to plugins. Resolves #93 #94

Merged
merged 9 commits into from
Feb 10, 2025

Conversation

DMJC
Copy link
Contributor

@DMJC DMJC commented Jan 14, 2025

This adds a new commandline option -p which you can feed a plugin name. e.g wcm -p input and it will launch wcm directly to the input plugin page. This allows us to integrate mate-control-center directly with WCM.

@DMJC DMJC changed the title Patch to add cli option for launching wcm directly to plugins. Patch to add cli option for launching wcm directly to plugins. Resolves #93 Jan 14, 2025
@DMJC
Copy link
Contributor Author

DMJC commented Jan 24, 2025

Can we get this workflow run again? I update the pull request.

@soreau
Copy link
Member

soreau commented Feb 9, 2025

This idea seems fine to me. The help and plugin-not-found messages might be adjusted, but we can do this later if needed. It would be nice if we could make it an error to pass -p without an argument. For the formatting changes, you can click 'Details' next to the uncrustify CI check and find a diff you can apply to make it pass.

@soreau
Copy link
Member

soreau commented Feb 9, 2025

For the build failure, it appears you need to back out your wdisplays submodule change.

@DMJC
Copy link
Contributor Author

DMJC commented Feb 9, 2025 via email

@soreau soreau merged commit 4eea9ce into WayfireWM:master Feb 10, 2025
2 checks passed
@soreau
Copy link
Member

soreau commented Feb 10, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants