Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix label image dimension mis match #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MikeLippincott
Copy link
Member

@MikeLippincott MikeLippincott commented Jan 25, 2025

Description

This PR fixed a bug referenced in issue #11. I added a check of array dimensions prior to concatenating labels with raw images

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch and fix! Leaving some comments here as I noticed this PR come up and had some thoughts. This might be a bit too preemptive and if so, apologies.

  • It looked like we might need a pre-commit run performed on this to help fix the newline issue (not absolutely certain).
  • Consider adding a test for this somehow to help make sure the new capability is validated. It could be possible to use the existing generate script under tests/data/... as an example of how to generate data for this. The variable under tests/utils.py can be used to add the test case to many of the existing tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants