Fix: tomli-w require binary mode

WangGithubUser · Jan 12, 2025 · 97a946a · 97a946a
1 parent 341a555
commit 97a946a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/client/commands/initialize.py b/client/commands/initialize.py
@@ -266,12 +266,13 @@ def get_configuration_and_path(
 def write_configuration(
     configuration: Dict[str, Any], configuration_path: Path
 ) -> None:
-    with open(configuration_path, "wb+") as configuration_file:
-        if configuration_path.suffix.lower() == ".toml":
+    if configuration_path.suffix.lower() == ".toml":
+        with open(configuration_path, "wb+") as configuration_file:
             configuration = {"tool": {"pyre": configuration}}  # [tool.pyre] section
             tomli_w.dump(configuration, configuration_file)
-        else:
-            # assume to JSON
+    else:
+        # assume to JSON
+        with open(configuration_path, "w+") as configuration_file:
             json.dump(configuration, configuration_file, sort_keys=True, indent=2)
         configuration_file.write("\n")
 

diff --git a/client/configuration/tests/configuration_test.py b/client/configuration/tests/configuration_test.py
@@ -1216,7 +1216,10 @@ def test_write_to_pyproject_dot_toml(self) -> None:
                 self.assertEqual(
                     configuration_file.read(),
                     """[tool.pyre]
-exclude = ["sample/exclude1", "sample/exclude2"]
+excludes = [
+    "sample/exclude1",
+    "sample/exclude2",
+]
 strict = true
 """,
                 )