feat(blockchainAPI): adding optional chainId parameter for the identity
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
geekbrother
commented
Sep 3, 2024
|
|
||
| * `address` - (Optional) Ethereum address to lookup for the ENS name and avatar. |
There was a problem hiding this comment.
Fixing this, address is not an optional parameter but is required.
zoruka
approved these changes
Sep 3, 2024
zoruka
reviewed
Sep 3, 2024
| `GET /v1/identity/{address}?projectId={projectId}` | ||
| `GET /v1/identity/{address}` | ||
|
|
||
| * `address` - Ethereum address to lookup for the ENS name and avatar. |
There was a problem hiding this comment.
I did overlook this, do we need to say that is a Ethereum address and is for ENS name?
There was a problem hiding this comment.
Good catch @zoruka ! We should remove this since the address can be Solana etc. starting from this change.
tomiir
approved these changes
Sep 3, 2024
chris13524
reviewed
Sep 3, 2024
Comment on lines
+16
to
+17
| * `chainId` - (Optional) CAIP-2 chain identifier to use for the address. | ||
| If it's not set the Ethereum mainnet and ENS resolution is used. |
There was a problem hiding this comment.
Clearly specifies the default. ENS resolution is unrelated
Suggested change
| * `chainId` - (Optional) CAIP-2 chain identifier to use for the address. | |
| If it's not set the Ethereum mainnet and ENS resolution is used. | |
| * `chainId` - (Optional) CAIP-2 chain identifier to use for the address. Defaults to `eip155:1` |
chris13524
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional
chainIdparameter for the/identityaddress -> name resolution to support anything other than the Ethereum ENS resolution.Related to the WalletConnect/blockchain-api#760