feat: adds expiry to proposal payload #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
llbartekll
reviewed
Jan 16, 2024
| @@ -85,7 +85,8 @@ Proposal is sent by the proposer client to be approved or rejected by the respon | |||
| "events": [string] | |||
| } | |||
| }, | |||
| "pairingTopic": string | |||
| "pairingTopic": string, | |||
| "expiry": number, // OPTIONAL timespamp in seconds | |||
There was a problem hiding this comment.
Suggested change
| "expiry": number, // OPTIONAL timespamp in seconds | |
| "expiry": number, // OPTIONAL time Interval Since 1970 in seconds``` |
jakubuid
approved these changes
Jan 17, 2024
llbartekll
approved these changes
Jan 18, 2024
jakubuid
reviewed
Jan 19, 2024
jakubuid
reviewed
Jan 23, 2024
| @@ -85,7 +85,8 @@ Proposal is sent by the proposer client to be approved or rejected by the respon | |||
| "events": [string] | |||
| } | |||
| }, | |||
| "pairingTopic": string | |||
| "pairingTopic": string, | |||
| "expiryTimestamp": number, // OPTIONAL timespamp in seconds | |||
There was a problem hiding this comment.
We should add expiryTimestamp on json rpc section for session proposal and session request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.