Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prisma-transaction): remove Promise.all in Prisma transaction #21

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

Cali93
Copy link
Collaborator

@Cali93 Cali93 commented Feb 7, 2024

Context

  • Removes Promise.all within the Prisma transaction as it seems to be the root cause of the errors we've seen lately
  • Environment variables have been updated (including DB credentials for prod, no more inconsistency between environments)
  • Updates dependencies
  • Removes Infura provider in favor of our Blockchain API provider
  • Contains latest relevant auth schema changes

Follow up issues to add tests, staging deployment and monitoring:

Closes #18
Closes https://github.com/WalletConnect/cloud-app/issues/970

@Cali93 Cali93 requested a review from bkrem February 7, 2024 10:41
Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice general overhaul here and setting of follow ups 💪

Removes Promise.all within the Prisma transaction as it seems to be the root cause of the errors we've seen lately

Why the suspected root cause being Promise.all?

Can we resolve the 500 we have in Sentry for SIWE and see if it a doesn’t regress and if it does, that it has a proper error message attached? Currently only errors as 500 with no context.

@Cali93
Copy link
Collaborator Author

Cali93 commented Feb 7, 2024

Why the suspected root cause being Promise.all?

I've come across some discussions like this one prisma/prisma#13564 and based on this issue prisma/prisma#21550 it doesn't seem like parallelizing queries within the transaction provides a performance gain.

Can we resolve the 500 we have in Sentry for SIWE and see if it a doesn’t regress and if it does, that it has a proper error message attached? Currently only errors as 500 with no context.

We will forward the error from now on (added in latest commit). I'll resolve the issue on Sentry as soon as this is deployed on prod.

@Cali93 Cali93 merged commit 1473561 into main Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(siwe): infura to our rpc
2 participants