[Translate] Einstein FTL #59
Conversation
WalkthroughThis pull request introduces multiple localization entries in Russian for various clothing items and objects within the application. New entities are defined across several files, including clothing wraps, neck accessories, prize tickets, and plush toys, each with corresponding descriptions to enhance user understanding and engagement. Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/objects/fun/prizeticket.ftl (1)
6-13: Consider including the ticket quantity in the entity names.The entities
ent-PrizeTicket10,ent-PrizeTicket30,ent-PrizeTicket60, andent-PrizeTicket1seem to represent different quantities of prize tickets. However, their names do not reflect this information.To provide clarity for the players, consider including the ticket quantity in the name of each entity.
For example, you could update the names as follows:
ent-PrizeTicket10 = { ent-PrizeTicketBase } (10 шт.) ent-PrizeTicket30 = { ent-PrizeTicketBase } (30 шт.) ent-PrizeTicket60 = { ent-PrizeTicketBase } (60 шт.) ent-PrizeTicket1 = { ent-PrizeTicketBase } (1 шт.)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/clothing/clothwarps.ftl (1 hunks)
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/clothing/neck/mantles.ftl (1 hunks)
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/clothing/neck/misc.ftl (1 hunks)
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/clothing/outerclothing/misc.ftl (1 hunks)
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/objects/fun/prizeticket.ftl (1 hunks)
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/objects/fun/puppet.ftl (1 hunks)
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/objects/fun/toys.ftl (1 hunks)
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/structures/machines/lathe.ftl (1 hunks)
Files skipped from review due to trivial changes (4)
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/clothing/clothwarps.ftl
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/clothing/neck/misc.ftl
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/clothing/outerclothing/misc.ftl
- Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/structures/machines/lathe.ftl
Additional comments not posted (27)
Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/clothing/neck/mantles.ftl (2)
1-2: LGTM!The entity
ent-ClothingNeckOldMantleis well-defined with a clear name and a detailed description in Russian. The description enhances the immersion by providing sensory details about the mantle's appearance and smell.
3-4: LGTM!The entity
ent-ClothingNeckUnathiMantleis well-defined with a clear name and a detailed description in Russian. The description enhances the immersion by providing an unsettling visual of the cloak's appearance.Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/objects/fun/puppet.ftl (5)
1-2: LGTM!The entity name and description translations for
ent-PetRockCarrierlook good.
4-5: LGTM!The entity name and description translations for
ent-BasePetRocklook good.
7-8: LGTM!The entity
ent-PetRockcorrectly inherits the name and description froment-BasePetRock.
9-10: LGTM!The entity name translation for
ent-PetRockFredlooks good and it correctly inherits the description froment-BasePetRock.
11-12: LGTM!The entity name translation for
ent-PetRockRoxielooks good and it correctly inherits the description froment-BasePetRock.Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/objects/fun/prizeticket.ftl (3)
1-2: LGTM!The name and description for
ent-PrizeTicketBaseare translated correctly and provide a clear explanation of the entity's purpose.
4-5: LGTM!
ent-PrizeTicketcorrectly inherits the name and description froment-PrizeTicketBase.
15-16: LGTM!The name and description for
ent-PrizeBallare translated correctly. The description adds an engaging element of mystery to the prize ball.Resources/Locale/ru-RU/prototypes/_einsteinengines/entities/objects/fun/toys.ftl (17)
1-2: LGTM!The name and description for
ent-PlushieArachneare appropriate and add personality to the toy. The syntax and formatting look good.
3-4: LGTM!The name and description for
ent-PlushieJesterare appropriate and add personality to the toy. The syntax and formatting look good.
5-6: LGTM!The name and description for
ent-PlushieSlipsare appropriate and add personality to the toy. The syntax and formatting look good.
7-8: LGTM!The name and description for
ent-PlushieGnomeare appropriate. The syntax and formatting look good.
9-10: LGTM!The name and description for
ent-PlushieLoveableare appropriate. The syntax and formatting look good.
11-12: LGTM!The name and description for
ent-PlushieDeerare appropriate. The syntax and formatting look good.
13-14: LGTM!The name and description for
ent-PlushieIpcare appropriate. The syntax and formatting look good.
15-16: LGTM!The name and description for
ent-PlushieGreyare appropriate. The syntax and formatting look good.
17-18: LGTM!The name and description for
ent-PlushieAbductorare appropriate. The syntax and formatting look good.
19-20: LGTM!The name and description for
ent-PlushieAbductorAgentare appropriate. The syntax and formatting look good.
22-23: LGTM!The name and description for
ent-PlushieRedFoxare appropriate and add personality to the toy. The syntax and formatting look good.
24-25: LGTM!The name and description for
ent-PlushiePurpleFoxare appropriate and add personality to the toy. The syntax and formatting look good.
26-27: LGTM!The name and description for
ent-PlushiePinkFoxare appropriate and add personality to the toy. The syntax and formatting look good.
28-29: LGTM!The name and description for
ent-PlushieOrangeFoxare appropriate and add personality to the toy. The syntax and formatting look good.
30-31: LGTM!The name and description for
ent-PlushieMarbleFoxare appropriate and add personality to the toy. The syntax and formatting look good.
32-33: LGTM!The name and description for
ent-PlushieCrimsonFoxare appropriate and add personality to the toy. The syntax and formatting look good.
34-35: LGTM!The name and description for
ent-PlushieCoffeeFoxare appropriate and add personality to the toy. The syntax and formatting look good.
|
Подправь переводы, чтобы они не были машинными. Ну это ужас какой-то, честное слово. |
"Не были машинными" - понятие растяжимое |
|
Я не думаю что стоит добавлять отдельную папку с переводами для EE |
Your new and only best friend home! -> Ваш новый и единственный лучший друг дома! Серьезно? |
|
Ужасы |
Описание PR
Перевод Игрушек ЕЕ и Xenowears.
Описание.
Медиа
Список
Изменения