[Port] Airlock / Шлюзы #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RSI Diff Bot; head commit 9ecc73f merging into 903f54f Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi
|
Remuchi
requested changes
Sep 7, 2024
|
|
|
|
|
|
WalkthroughThe pull request introduces several modifications to the airlock system in the game. Key changes include updates to visibility logic for airlock lights, adjustments to default settings for the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant AirlockSystem
participant AirlockComponent
Client->>AirlockSystem: Request appearance change
AirlockSystem->>AirlockComponent: Check door state
AirlockComponent-->>AirlockSystem: Return visibility status
AirlockSystem-->>Client: Update appearance
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
Resources/Prototypes/Entities/Structures/Doors/Airlocks/highsec.yml (1)
11-11: Sprite file not found in the repository.The sprite path
_White/Structures/Doors/Airlocks/highsec/highsec.rsiis referenced in the codebase but the file does not exist in the repository. Please ensure that the file is added to the project resources.
- Referenced in:
Resources/Prototypes/Entities/Structures/Doors/Airlocks/highsec.ymlResources/Prototypes/Entities/Structures/Doors/Airlocks/assembly.ymlAnalysis chain
Verify new sprite path.
The change to the sprite path is noted and appears to be part of a visual update. Please ensure that the file
_White/Structures/Doors/Airlocks/highsec/highsec.rsiexists and is accessible in the project's resources.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the existence of the new sprite path. # Test: Check if the new sprite path exists. Expect: Path should exist. fd '_White/Structures/Doors/Airlocks/highsec/highsec.rsi'Length of output: 57
Script:
#!/bin/bash # Re-verify the existence of the new sprite path using ripgrep. # Test: Check if the new sprite path exists. Expect: Path should exist. rg '_White/Structures/Doors/Airlocks/highsec/highsec.rsi'Length of output: 344
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (278)
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/deny.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/locked.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/welded_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/assembly-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/assembly-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing-panel.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening-panel.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/panel_closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/emergency_open_unlit.pngis excluded by!**/*.png
Files selected for processing (22)
- Content.Client/Doors/AirlockSystem.cs (1 hunks)
- Content.Shared/Doors/Components/AirlockComponent.cs (1 hunks)
- Resources/Prototypes/DeltaV/Entities/Structures/Doors/Airlocks/airlocks.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/airlocks.yml (17 hunks)
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/assembly.yml (33 hunks)
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/base_structureairlocks.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/clockwork.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/external.yml (2 hunks)
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/highsec.yml (1 hunks)
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/shuttle.yml (5 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/meta.json (1 hunks)
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/meta.json (1 hunks)
Files skipped from review due to trivial changes (6)
- Resources/Prototypes/DeltaV/Entities/Structures/Doors/Airlocks/airlocks.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/airlocks.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/assembly.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/clockwork.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/external.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/shuttle.yml
Additional comments not posted (22)
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json (1)
1-162: Approve metadata file with a note on copyright.This new metadata file is well-structured and includes comprehensive details for various states of the airlock. Ensure that the copyright notice is compliant with the original source's requirements and that the WD team has the necessary permissions to use and modify the content.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/meta.json (1)
1-186: Approve metadata file with a note on copyright.This metadata file is consistent with the expected format and provides detailed animation states for the airlock. As with the previous file, ensure that the copyright notice is compliant with the original source's requirements and that the WD team has the necessary permissions to use and modify the content.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/clockwork_pinion.rsi/meta.json (3)
2-4: Check licensing and copyright details.Ensure that the licensing (
CC-BY-SA-3.0) and the detailed copyright information are correct and legally compliant, especially since the assets are taken and modified from another project.
5-8: Confirm texture dimensions.The specified dimensions (
32x32) should match the actual size of the provided textures. This is crucial for ensuring that the textures render correctly in the game.
9-176: Review animation states and delays.Each state, such as
closed,opening, anddeny_unlit, has associated delays which control the animation speed. Verify that these delays:
- Are consistent with the game's animation standards.
- Provide a smooth visual experience without being too fast or slow.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/meta.json (3)
2-4: Check licensing and copyright details.As with the previous file, confirm that the licensing and copyright details are accurate and compliant, especially considering the modifications made by the WD team.
5-8: Confirm texture dimensions.Ensure the dimensions (
32x32) are correctly set to match the actual texture files used in the game, to prevent any rendering issues.
9-202: Review animation states and delays.Check that the animation states and their respective delays are suitable for the atmospherics airlocks, ensuring they align with the expected behavior and visual standards of the game.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/meta.json (3)
2-4: Check licensing and copyright details.Verify the accuracy and compliance of the licensing (
CC-BY-SA-3.0) and copyright details, particularly the modifications attributed to the WD team.
5-8: Confirm texture dimensions.The dimensions (
32x32) need to be verified against the actual texture files to ensure they are correctly set for optimal rendering.
9-204: Review animation states and delays.Ensure that the animation states and delays for the basic airlock type are correctly set to provide a consistent and smooth visual experience in the game.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/meta.json (1)
1-204: Well-structured JSON for airlock states and animations.The JSON file is well-organized and clearly defines various states and animations for the airlocks, with appropriate metadata including copyright, license, and version information. The use of animation delays is a good practice for detailed control over sprite animations.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/meta.json (1)
1-204: Consistent and well-structured JSON for airlock states and animations.This JSON file, like the previous one, is well-organized and clearly defines various states and animations for the airlocks, with appropriate metadata including copyright, license, and version information. The consistency across different airlock types is good for maintainability.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/meta.json (1)
1-204: Consistently structured JSON for airlock states and animations.This JSON file maintains the same high level of organization and clarity in defining various states and animations for the airlocks as seen in the previous files. The uniformity across different airlock types ensures ease of maintenance and consistency in game behavior.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/meta.json (1)
1-204: Comprehensive Review of New Metadata FileThe new metadata file for airlock textures is well-structured and includes all necessary information. Here are some specific observations:
- Version and License: The file specifies the version and license clearly (
CC-BY-SA-3.0), which is crucial for open-source compliance.- Copyright: The source of the textures is attributed to
tgstation, with modifications by the WD team. This is important for copyright compliance.- Animation States and Delays: The file defines multiple states such as
closed,opening,closing, etc., with specific delays for animations. These should be verified to ensure they align with the intended gameplay mechanics and performance expectations.Overall, the file appears to be correctly set up for the game's requirements, assuming the animation timings are as intended for gameplay. It would be beneficial to ensure that these settings are tested in the game environment to confirm their effectiveness and performance.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/meta.json (1)
1-204: Consistent Metadata Across Airlock TexturesThis metadata file for the maintenance airlock textures mirrors the structure and content of the engineering airlock metadata file reviewed earlier. Key points include:
- Consistency: The file maintains consistency with the engineering airlock metadata, which is good for uniformity across different airlock types.
- Animation States and Delays: Similar to the previous file, it includes various states with specific animation delays. Consistency in animation behavior across different airlocks is important for player expectations and game feel.
Assuming the animation timings are appropriate for the gameplay experience, this file also appears to be correctly set up. It is recommended to perform in-game testing to verify the animations and ensure they meet performance standards.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/justice.rsi/meta.json (1)
1-204: Uniform Metadata with Specific Copyright MentionThis metadata file for the justice department airlock textures is consistent with the other airlock metadata files, with the addition of a specific mention for recoloring by
leonardo_dabepis (Discord). Key points include:
- Copyright: The additional mention of recoloring should be verified for accuracy and proper attribution, ensuring that all contributors are correctly acknowledged.
- Animation States and Delays: The file includes the same states and animation delays as the other airlock types, which is important for maintaining a consistent user experience across the game.
The file is well-prepared, assuming the copyright details are correct and the animation timings are suitable for the intended gameplay dynamics. As with the other files, in-game testing is recommended to confirm the animations' effectiveness and performance.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/meta.json (1)
1-258: Metadata structure and content are well-defined.The metadata file for airlock textures is comprehensive and well-organized. It includes all necessary information such as version, license, copyright, size, and detailed states with animations. This ensures that the airlock textures are properly managed and utilized within the game.
Content.Shared/Doors/Components/AirlockComponent.cs (1)
79-79: Visibility enhancement approved.The change to
OpenUnlitVisiblefromfalsetotrueis approved as it enhances visibility, which can improve user experience in gameplay. It is recommended to verify the impact on gameplay to ensure that this change positively affects player interactions with airlocks.Run the following script to verify the impact on gameplay:
Resources/Prototypes/Entities/Structures/Doors/Airlocks/base_structureairlocks.yml (2)
14-14: Sprite path update approved.The update to the sprite path for the Standard airlock to include the
_Whiteprefix is approved. It is recommended to verify the consistency of this new visual theme across other related assets in the game to ensure a uniform appearance.Run the following script to verify the consistency across other related assets:
Verification successful
Consistency of
_Whiteprefix confirmed across assets.The
_Whiteprefix is consistently applied across various sprite paths, indicating a deliberate and uniform visual theme implementation. This confirms the change is part of a broader update. No further action is required.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of the `_White` prefix across other related assets. # Test: Search for the `_White` prefix in other sprite paths. rg --type yaml "_White"Length of output: 13556
177-177: Sprite path update approved.The update to the sprite path for the Glass airlock to include the
_Whiteprefix is approved. It is recommended to verify the consistency of this new visual theme across other related assets in the game to ensure a uniform appearance.Run the following script to verify the consistency across other related assets:
Verification successful
Sprite path update consistency verified.
The
_Whiteprefix is consistently applied across various sprite paths, including different types of airlocks and other entities. This confirms a cohesive visual update across the game assets. The change is approved as it aligns with the intended visual theme.
- The
_Whiteprefix is used in multiple files, ensuring a uniform appearance across related assets.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of the `_White` prefix across other related assets. # Test: Search for the `_White` prefix in other sprite paths. rg --type yaml "_White"Length of output: 13556
Content.Client/Doors/AirlockSystem.cs (1)
93-100: Review of Visibility Logic Changes inOnAppearanceChangeThe changes in the visibility logic for
unlitVisibleare significant as they extend the conditions under which an airlock can appear unlit. Previously, the visibility was only set based on theOpenstate combined with theOpenUnlitVisibleproperty. The new logic now includes theClosedstate as well, which broadens the scenarios under which the airlock can appear unlit.This change aligns with the PR's objective to enhance visual representation and interactivity of airlocks. However, it's crucial to ensure that this logic does not introduce any unintended side effects, especially in terms of how it interacts with other airlock states and properties.
Suggestions:
- Verification Needed: Verify that the new condition (
state == DoorState.Closed && comp.OpenUnlitVisible) does not conflict with other airlock behaviors, particularly in scenarios where the airlock might need to appear differently when powered or during emergency situations.- Testing: It would be beneficial to add or update unit tests to cover these new conditions to ensure they behave as expected without affecting other functionalities.
Remuchi
approved these changes
Sep 9, 2024
riddleridou
added a commit
that referenced
this pull request
Sep 9, 2024
This was referenced Sep 11, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Порт наших текстур шлюзов и пару фиксов
Изменения
🆑 Spatison
Summary by CodeRabbit
New Features
Asset Updates
Bug Fixes