Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Grab / Захват #23

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[Feature] Grab / Захват #23

wants to merge 5 commits into from

Conversation

Spatison
Copy link
Member

@Spatison Spatison commented Aug 28, 2024

Описание PR

За основу взят: #30011.


Медиа

Видео


Список

  • Добавить WD EDIT

Изменения

🆑 Spatison

  • add: Added grab / Добавлен захват

Copy link
Contributor

github-actions bot commented Aug 28, 2024

RSI Diff Bot; head commit 4eccaa2 merging into 419edd6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Alerts/pull.rsi

State Old New Status
grab-choke Added
grab-hard Added
grab-soft Added
grabbed-choke Added
grabbed-hard Added
grabbed-soft Added
pulled Added
pulling Added

Edit: diff updated after 4eccaa2

@Spatison Spatison marked this pull request as ready for review August 28, 2024 10:42
Copy link
Collaborator

@Remuchi Remuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По коду пока сказать детальнее не могу, скажу с точки зрения фичи самой

  1. Шансы вырваться и взять в захват должны зависеть от массы двух сущностей. Смотри MassContest.
  2. Система вырывания из захвата, завязанная на чистом рандоме - плохо. Должен быть какой-то хард-лимитер. Условно если шанс вырваться 10%, то после 10 попыток 11 должна быть успешной в любом случае.
  3. Из захвата можно вырваться сугубо нажатием на алерт. Движение или кнопка Отпустить не работают.
  4. При взятии кого-то в удушение ломается предикт.
  5. В целом система моментального улучшения граба с софта до агрессив.... звучит не очень. Должно работать так - взятие в хардграб должно быть ду-афтером (время зависит от MassContest, опять таки, но усредненно должно быть в районе 0.5с). Взятие в удушение должно иметь ду-афтер дольше, в районе 2-3 секунд.
  6. Переход в удушающую стойку должен ложить человека на землю. И выключать ему руки.

@Spatison Spatison marked this pull request as draft September 2, 2024 20:48
Copy link
Contributor

github-actions bot commented Sep 5, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

coderabbitai bot commented Sep 5, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Spatison Spatison self-assigned this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants