Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save pipeline connections in a consistent order #922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamCarlberg
Copy link
Member

Fixes a problem with logical operations (and linked input sockets in general) having output connections deserialized prior to input connections, which lead to crashes when loading save files with operations that use linked input sockets.

Old save files using logical operations remain unusable, but creating a save file with those operations will guarantee a readable save file.

Fixes #919

Fixes a problem with logical operations (and linked input sockets in general) having output connections deserialized prior to input connections, which lead to crashes when loading save files with operations that use linked input sockets
@SamCarlberg SamCarlberg added the type: bugfix Fixes one or more open bugs label Feb 9, 2019
@codecov-io
Copy link

Codecov Report

Merging #922 into master will increase coverage by 0.14%.
The diff coverage is 70.14%.

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
+ Coverage    54.5%   54.65%   +0.14%     
==========================================
  Files         304      305       +1     
  Lines        8318     8385      +67     
  Branches      535      540       +5     
==========================================
+ Hits         4534     4583      +49     
- Misses       3587     3605      +18     
  Partials      197      197

Copy link
Member

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test if possible. Other than that, this looks good!

@SamCarlberg SamCarlberg added this to the v1.6.0 milestone Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bugfix Fixes one or more open bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants