Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build bash script added #278

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build bash script added #278

wants to merge 2 commits into from

Conversation

gsingh-ds
Copy link

No description provided.

webJose
webJose requested changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@webJose webJose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide examples on how this is used? Thanks!

build-bash.sh Outdated
cp ./src/ex.d.ts ./out/ex/index.d.ts

# Publish or dry run publish
if [ "$PUBLISH" = "true" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, the PowerShell version disallows publishing if the unit tests are skipped. This should do the same.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. anything else?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the example it's just. yarn/npm bash-build, I didn't saw anything in readme about build. where you want me to add the example?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webJose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Apologies. Yes, I have this in my pendings. I am in the middle of authoring a client-sided Svelte router for Svelte v5, and that has taken the time away from me. No worries. I'll get to this. I'll be on vacation all of February.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webJose webJose webJose requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gsingh-ds @webJose