Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECDSA P-256 SHA-256 implementation #888

Merged
merged 6 commits into from
Apr 30, 2024
Merged

ECDSA P-256 SHA-256 implementation #888

merged 6 commits into from
Apr 30, 2024

Conversation

GrapeGreen
Copy link
Collaborator

This PR implements support for the ECDSA P-256 SHA-256 signing scheme for wbn-sign.

@GrapeGreen GrapeGreen requested review from sonkkeli and cmfcmf April 24, 2024 17:06
sonkkeli
sonkkeli reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@sonkkeli sonkkeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing still on the github workflow, could you fix those as well

js/sign/package.json Outdated Show resolved Hide resolved
js/sign/src/signers/node-crypto-signing-strategy.ts Show resolved Hide resolved
js/sign/src/utils/constants.ts Outdated Show resolved Hide resolved
js/sign/src/utils/utils.ts Outdated Show resolved Hide resolved
js/sign/src/web-bundle-id.ts Outdated Show resolved Hide resolved
cmfcmf
cmfcmf reviewed Apr 25, 2024
View reviewed changes
js/sign/src/signers/node-crypto-signing-strategy.ts Show resolved Hide resolved
js/sign/src/utils/utils.ts Outdated Show resolved Hide resolved
js/sign/src/utils/utils.ts Outdated Show resolved Hide resolved
js/sign/tests/integrity-block-signer_test.js Outdated Show resolved Hide resolved
js/sign/tests/integrity-block-signer_test.js Outdated Show resolved Hide resolved
sonkkeli
sonkkeli approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@sonkkeli sonkkeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please wait for @cmfcmf's lgtm too :)

(Sidenote: the currently failing builds are not your fault and they always fail so you can ignore those)

cmfcmf
cmfcmf approved these changes Apr 26, 2024
View reviewed changes
Copy link
Collaborator

@cmfcmf cmfcmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

js/sign/tests/integrity-block-signer_test.js Outdated Show resolved Hide resolved
js/sign/src/utils/utils.ts Outdated Show resolved Hide resolved
sonkkeli
sonkkeli reviewed Apr 30, 2024
View reviewed changes
js/sign/README.md Outdated Show resolved Hide resolved
cmfcmf
cmfcmf approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@cmfcmf cmfcmf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GrapeGreen GrapeGreen merged commit 2187f0d into WICG:main Apr 30, 2024
10 of 12 checks passed
@GrapeGreen GrapeGreen deleted the js_sign_ecdsa branch July 9, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonkkeli sonkkeli sonkkeli approved these changes

@cmfcmf cmfcmf cmfcmf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GrapeGreen @cmfcmf @sonkkeli