Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to the Chrome bidding and auction server API #602

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

brusshamilton
Copy link
Contributor

No description provided.

aarongable pushed a commit to chromium/chromium that referenced this pull request Jun 13, 2023
This will be used when we complete auction in browser.

Related resources:

https://github.com/WICG/turtledove/blob/main/FLEDGE_browser_bidding_and_auction_API.md#step-4-complete-auction-in-browser

WICG/turtledove#602


Bug: 1442274
Change-Id: If35959def123d3cc30ed7ef0366fc9a186cbbfa6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595558
Reviewed-by: Russ Hamilton <[email protected]>
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Youssef Bourouphael <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1157121}
@JensenPaul JensenPaul added the Non-breaking Feature Request Feature request for functionality unlikely to break backwards compatibility label Jun 22, 2023
@brusshamilton
Copy link
Contributor Author

I fixed the merge issues and clarified the framing we are using. PTAL

Copy link
Collaborator

@JensenPaul JensenPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. I just left a few tiny comments that, once addresssed, I'll merge this PR.

FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
FLEDGE_browser_bidding_and_auction_API.md Outdated Show resolved Hide resolved
@brusshamilton
Copy link
Contributor Author

I think I addressed all of the outstanding comments. PTAL

@JensenPaul JensenPaul merged commit 0f50df9 into WICG:main Sep 12, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Sep 12, 2023
SHA: 0f50df9
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@brusshamilton brusshamilton deleted the schema branch August 23, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-breaking Feature Request Feature request for functionality unlikely to break backwards compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants