Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requiredSellerCapabilities check when processing auctionReportBuyers #1323

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexmturner
Copy link
Contributor

@alexmturner alexmturner commented Nov 4, 2024

Recreates patcg-individual-drafts/private-aggregation-api#134 now that the monkey patches have been incorporated into this repo.


Preview | Diff

@alexmturner
Copy link
Contributor Author

@morlovich, could you PTAL? Just realized I never got back to you on your earlier PR; so, recreated it here.

To be honest, I still don't quite understand the new check here -- the explainer seems to indicate that such buyers would be entirely excluded from the auction (ref). But I defer to you on what's most aligned with the implementation.

@morlovich
Copy link
Collaborator

So the motivation was that, despite these buyers being excluded from the auction, our implementation currently can still report interest group counts for them (if they had that capability but not some other reported capability). I don't remember the context of the spec change, though, and at this very moment my brain is too loaded with another task to work out whether the spec part is needed. My intent of sending the spec change was to nail down if our behavior needed to be changed, though.

@JensenPaul JensenPaul added the spec Relates to the spec label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Relates to the spec
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants