Skip to content

Commit

Permalink
Fix buglet in setPrioritySignals. (#712)
Browse files Browse the repository at this point in the history
The second argument can be omitted/set to null/undefined to erase
mapping for a key. The actual handling logic was already handling
that, but we were not accepting this in the signature, or permitting in
the infra rep.

Co-authored-by: Maks Orlovich <[email protected]>
  • Loading branch information
morlovich and Maks Orlovich authored Jul 24, 2023
1 parent ca91517 commit 5db06b2
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -2299,7 +2299,7 @@ interface InterestGroupBiddingScriptRunnerGlobalScope
: InterestGroupScriptRunnerGlobalScope {
boolean setBid(optional GenerateBidOutput generateBidOutput = {});
undefined setPriority(double priority);
undefined setPrioritySignalsOverride(DOMString key, double priority);
undefined setPrioritySignalsOverride(DOMString key, optional double? priority);
};

dictionary AdRender {
Expand Down Expand Up @@ -2328,7 +2328,7 @@ Each {{InterestGroupBiddingScriptRunnerGlobalScope}} has a
: <dfn>priority</dfn>
:: Null or a {{double}}
: <dfn>priority signals</dfn>
:: An [=ordered map=] whose [=map/keys=] are [=strings=] and whose [=map/values=] are {{double}}
:: An [=ordered map=] whose [=map/keys=] are [=strings=] and whose [=map/values=] are {{double}} or null.
: <dfn>interest group</dfn>
:: An [=interest group=]
: <dfn>expected currency</dfn>
Expand Down

0 comments on commit 5db06b2

Please sign in to comment.