Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check algorithms that get null after closing #98

Merged
merged 1 commit into from
Jan 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,8 @@ The <dfn attribute for=Subscriber><code>signal</code></dfn> getter steps are to
1. If [=this=]'s [=relevant global object=] is a {{Window}} object, and its [=associated
Document=] is not [=Document/fully active=], then return.

1. Run [=this=]'s [=Subscriber/next algorithm=] algorithm given |value|.
1. If [=this=]'s [=Subscriber/next algorithm=] is not null, then run [=this=]'s
[=Subscriber/next algorithm=] given |value|.

[=Assert=]: No <a spec=webidl lt="an exception was thrown">exception was thrown</a>.
</div>
Expand All @@ -214,10 +215,12 @@ The <dfn attribute for=Subscriber><code>signal</code></dfn> getter steps are to

1. [=close a subscription|Close=] [=this=].

1. Run |error algorithm| given |error|.
1. If |error algorithm| is not null, then run |error algorithm| given |error|.

[=Assert=]: No <a spec=webidl lt="an exception was thrown">exception was thrown</a>.

1. Otherwise (i.e., when |error algorithm| is null), [=report the exception=] |error|.

1. [=AbortController/Signal abort=] [=this=]'s [=Subscriber/complete or error controller=].
</div>

Expand All @@ -231,7 +234,7 @@ The <dfn attribute for=Subscriber><code>signal</code></dfn> getter steps are to

1. [=close a subscription|Close=] [=this=].

1. Run |complete algorithm|.
1. If |complete algorithm| is not null, then run |complete algorithm|.

[=Assert=]: No <a spec=webidl lt="an exception was thrown">exception was thrown</a>.

Expand Down