Update examples #83
Update examples #83
Conversation
|
It looks like there are conflicts in this PR now because this PR somehow contained all of the "prettier" changes that the PR did. |
|
Ping :) |
…have imperative versions for each example. Adds a new example that creates a measuring tool to measure distance on the page.
benlesh
force-pushed
the
benlesh/update-examples
branch
from
7dea4cc to
82be7a9
Compare
|
Weird... That diff was gnarly. I just redid the changes on top of master. |
README.md
Outdated
| element.addEventListener( | ||
| 'mousemove', | ||
| (e) => { | ||
| element.addEventListener('mouseup', (e) => controller.abort()); | ||
| element.addEventListener('mouseup', (e) => ac.abort(), { | ||
| signal: controller.signal, |
There was a problem hiding this comment.
This would have to be ac.signal, since controller shouldn't exist. But also, why do we have to pass it in here anyways, if the previous version of this example wasn't?
There was a problem hiding this comment.
Looks like you didn't get to this:
But also, why do we have to pass it in here anyways, if the previous version of this example wasn't?
Co-authored-by: Dominic Farolino <[email protected]>
| const { clientX: startX, clientY: startY } = e; | ||
|
|
||
| const svg = document.createElement('svg'); | ||
| svg.width = document.body.width; |
|
@benlesh do you plan on finishing this? |
|
I'm going to close this since there is no activity. Feel free to re-open if you want to finish this. |
|
Sorry... I've just been busy with personal life things. I'll try to circle back to this soon. |
Updates the examples to reflect recent changes. Also ensures that we have imperative versions for each example.
Adds a new example that creates a measuring tool to measure distance on the page.