We should forward the subscribers abort signal to eventListeners #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @domfarolino |
domfarolino
reviewed
Dec 11, 2024
maraisr
force-pushed
the
mr/event-abort
branch
from
6a737d2 to
c81de62
Compare
|
Thank you so much for your review here @domfarolino, I have addressed the points. You're so good at this spec stuff. Learning a bunch. |
domfarolino
approved these changes
Dec 12, 2024
maraisr
force-pushed
the
mr/event-abort
branch
from
c81de62 to
391600b
Compare
|
@domfarolino I have rebased from the current master. Let's hope that fixes the CI. |
github-actions bot
added a commit
that referenced
this pull request
Dec 12, 2024
SHA: 5df4a38 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is a possible event listener leak that can occur if we don't have a mechanism to clean up event listeners as subscriptions are aborted.
In WebKit I confirmed, that if we were to follow the spec we'd keep listeners around for a little too long:
Much like Chrome's EventTarget implementation, WebKits' also immediately take ownership of the EventListener, so that despite the Observable is marked for GC (
active == 0), the listener hangs around.and I think Chrome had a similar discovery, as they also forward the signal to the event listener to trigger the abort steps.
Preview | Diff