Pass abortsignal reason to close a subscription #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
force-pushed
the
pass-abortsignal-reason-to-close-a-subscription
branch
2 times, most recently
from
2e0a937 to
85e4753
Compare
keithamus
force-pushed
the
pass-abortsignal-reason-to-close-a-subscription
branch
from
85e4753 to
c1ac731
Compare
domfarolino
reviewed
Jul 30, 2024
spec.bs
Outdated
| @@ -37,6 +37,7 @@ urlPrefix: https://dom.spec.whatwg.org; spec: DOM | |||
| for: AbortSignal | |||
| text: dependent signals; url: abortsignal-dependent-signals | |||
| text: signal abort; url:abortsignal-signal-abort | |||
| text: reason; url:abortsignal-abort-reason | |||
There was a problem hiding this comment.
Just to double check, is this needed? I guess it is, but I'm surprised by this. It makes me wonder if we're holding AbortSignal wrong — I would expect this to be exported so other specs that use AbortSignals can propagate reasons similarly.
spec.bs
Outdated
|
|
||
| Issue: Abort with an appropriate abort reason. | ||
| Issue: Abort with an appropriate abort reason if none given. |
There was a problem hiding this comment.
I don't think this is needed at all now. We don't need to supply a "fallback" default reason if none was provided.
domfarolino
changed the title
domfarolino
approved these changes
Aug 13, 2024
|
I cleaned a few things up here. I think it's good to go now so I'll merge. |
domfarolino
deleted the
pass-abortsignal-reason-to-close-a-subscription
branch
github-actions bot
added a commit
that referenced
this pull request
Aug 13, 2024
SHA: d5a14ab Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165.
This seems to marry up with Chrome's impl:
Preview | Diff