Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SubscriptionObserverCallback to ObservableSubscriptionCallback #157

Conversation

keithamus
Copy link
Collaborator

@keithamus keithamus commented Jul 16, 2024

@maraisr and I have renamed SubscriptionObserverCallback to ObservableSubscriptionCallback based on review feedback from @rreno here


Preview | Diff

@keithamus keithamus requested review from benlesh and domfarolino July 17, 2024 08:17
@domfarolino domfarolino changed the title rename SubscriptionObserverCallback to ObservableSubscriptionCallback Rename SubscriptionObserverCallback to ObservableSubscriptionCallback Jul 22, 2024
@domfarolino domfarolino changed the title Rename SubscriptionObserverCallback to ObservableSubscriptionCallback Rename SubscriptionObserverCallback to ObservableSubscriptionCallback Jul 22, 2024
spec.bs Outdated Show resolved Hide resolved
Co-authored-by: Dominic Farolino <[email protected]>
@domfarolino domfarolino merged commit e5238cb into master Jul 22, 2024
2 checks passed
@domfarolino domfarolino deleted the rename-subscriptionobservercallback-to-observablesubscriptioncallback branch July 22, 2024 14:14
github-actions bot added a commit that referenced this pull request Jul 22, 2024
…ack` (#157)

SHA: e5238cb
Reason: push, by domfarolino

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants