-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec the switchMap
operator
#130
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 1, 2024
See WICG/observable#130 for the spec PR, and https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for documentation about the `flatMap()` operator, which is structured in almost the same way as `switchMap()`. [email protected] Bug: 40282760 Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 1, 2024
See WICG/observable#130 for the spec PR, and https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for documentation about the `flatMap()` operator, which is structured in almost the same way as `switchMap()`. [email protected] Bug: 40282760 Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 1, 2024
See WICG/observable#130 for the spec PR, and https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for documentation about the `flatMap()` operator, which is structured in almost the same way as `switchMap()`. [email protected] Bug: 40282760 Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1280836}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 1, 2024
See WICG/observable#130 for the spec PR, and https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for documentation about the `flatMap()` operator, which is structured in almost the same way as `switchMap()`. [email protected] Bug: 40282760 Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1280836}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 1, 2024
See WICG/observable#130 for the spec PR, and https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for documentation about the `flatMap()` operator, which is structured in almost the same way as `switchMap()`. [email protected] Bug: 40282760 Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1280836}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 10, 2024
…ble operator, a=testonly Automatic update from web-platform-tests DOM: Implement the `switchMap()` Observable operator See WICG/observable#130 for the spec PR, and https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for documentation about the `flatMap()` operator, which is structured in almost the same way as `switchMap()`. [email protected] Bug: 40282760 Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1280836} -- wpt-commits: bd3b4d15f91c5b9b80295c81b890e45a44a9699a wpt-pr: 45452
benlesh
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly okay, just a couple of things that I caught.
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Apr 15, 2024
…ble operator, a=testonly Automatic update from web-platform-tests DOM: Implement the `switchMap()` Observable operator See WICG/observable#130 for the spec PR, and https://chromium-review.googlesource.com/c/chromium/src/+/5381640 for documentation about the `flatMap()` operator, which is structured in almost the same way as `switchMap()`. [email protected] Bug: 40282760 Change-Id: Id2b0de2d60dd985be843f154bebd66f8948f36f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5410391 Reviewed-by: Mason Freed <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1280836} -- wpt-commits: bd3b4d15f91c5b9b80295c81b890e45a44a9699a wpt-pr: 45452
I think everything is addressed here so I am going to land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR spec's the
switchMap()
operator.This PR closes #52 and makes progress on #126.
Preview | Diff