Make "no-referrer" censor cross-document AppHistoryEntry URLs #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also be clear that, despite the shaky spec foundations, the intent after this fix is to expose session history entries across browsing context group swaps. Closes #71.
natechapin
approved these changes
Nov 17, 2021
annevk
reviewed
Nov 18, 2021
| 1. If [=this=]'s [=relevant global object=]'s [=associated Document=] is not [=Document/fully active=], then return the empty string. | ||
| 1. If [=this=]'s [=relevant global object=]'s [=associated Document=] is not [=Document/fully active=], then return null. | ||
| 1. Let |she| be [=this=]'s [=AppHistoryEntry/session history entry=]. | ||
| 1. If |she|'s [=session history entry/document=] does not equal [=this=]'s [=relevant global object=]'s [=associated Document=], and |she|'s [=session history entry/policy container=]'s [=policy container/referrer policy=] is <a>"`no-referrer`"</a>, then return null. |
There was a problem hiding this comment.
Nit: no need for comma before and (while it looks like a lot of words, that's mostly in the source).
|
I don't think we want to protect those:
|
|
I was thinking you might want to have private state just for history entries on that document. I think I'm okay with not going to those lengths though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also be clear that, despite the shaky spec foundations, the intent after this fix is to expose session history entries across browsing context group swaps.
Closes #71.
Preview | Diff