Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inline-speculation-rules use with nonce, hash, and strict-dynamic #268

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

toyoshim
Copy link
Contributor

"Does a source list allow all inline behavior for type?" defines an algorithm, and it is designed to ignore 'unsafe-inline' and 'inline-speculation-rules' when one of nonce, hash, or strict-dynamic presents.

For 'inline-speculation-rules', this is not beneficial. So, this patch updates the spec patch not to ignore 'inline-speculation-rules' in the algorithm.

"Does a source list allow all inline behavior for type?" defines
an algorithm, and it is designed to ignore 'unsafe-inline' and
'inline-speculation-rules' when one of nonce, hash, or strict-dynamic
presents.

For 'inline-speculation-rules', this is not beneficial. So, this
patch updates the spec patch not to ignore 'inline-speculation-rules'
in the algorithm.
@github-actions
Copy link

Preview:

@toyoshim
Copy link
Contributor Author

This is a feedback from https://bugs.chromium.org/p/chromium/issues/detail?id=1433616
@jeremyroman can you take a look?
@mikewest can you also take a look from the CSP perspective?

@jeremyroman
Copy link
Collaborator

Since I missed this at the time and I think there's been further discussion since, can I just check whether this is still current? If so I can take a look.

@domenic
Copy link
Collaborator

domenic commented May 18, 2023

We got pushback from @mikewest internally on this, suggesting that instead we use workarounds to accomplish the same goals. I don't agree with that pushback, as I think it makes the platform less comprehensible, but I think we're currently stuck here.

@toyoshim toyoshim marked this pull request as draft June 6, 2023 00:33
@toyoshim
Copy link
Contributor Author

toyoshim commented Jun 6, 2023

Thanks @domenic to share the context here.
I changed the status to Draft as we would not go without resolving CSP people's concerns, and I could not spend enough time on this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants