-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watch for [data-inert] elements and turn them inerted as well (#126) #128
Open
babielmam
wants to merge
6
commits into
WICG:main
Choose a base branch
from
babielmam:GH-126
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2368f0d
watch for [data-inert] elements and turn them inerted as well (#126)
MaxMuehlbauer 63adcdb
Merge branch 'master' into GH-126
babielmam 4f96ff3
GH-126: integrate data-inert as an alternative for inert-attribute more
babielmam 2ed6844
GH-126: refactoring and adding more tests for data-attributes
babielmam b0623d9
GH-126: refactoring general condition checks into functions
babielmam a13fe96
GH-126: fix bug where condition is inversed
babielmam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ | |
"code": 100, | ||
"tabWidth": 2, | ||
"ignoreUrls": true | ||
}] | ||
}], | ||
"linebreak-style": ["error", "windows"] | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
<!-- | ||
This work is licensed under the W3C Software and Document License | ||
(http://www.w3.org/Consortium/Legal/2015/copyright-software-and-document). | ||
--> | ||
|
||
<div data-inert> | ||
<button>Click Me</button> | ||
<div id="fake-button" tabindex="0">Click me</div> | ||
</div> | ||
<button id="non-inert">Non-inert button</button> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
describe('Data-Attribute', function() { | ||
before(function() { | ||
fixture.setBase('test/fixtures'); | ||
}); | ||
|
||
beforeEach(function(done) { | ||
fixture.load('data-attribute.html'); | ||
// Because inert relies on MutationObservers, | ||
// wait till next microtask before running tests. | ||
setTimeout(function() { | ||
done(); | ||
}, 0); | ||
}); | ||
|
||
afterEach(function() { | ||
fixture.cleanup(); | ||
}); | ||
|
||
it('should make implicitly focusable child not focusable', function() { | ||
var button = fixture.el.querySelector('[data-inert] button'); | ||
expect(isUnfocusable(button)).to.equal(true); | ||
}); | ||
|
||
it('should make explicitly focusable child not focusable', function() { | ||
var div = fixture.el.querySelector('#fake-button'); | ||
expect(div.hasAttribute('tabindex')).to.equal(false); | ||
expect(isUnfocusable(div)).to.equal(true); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add some tests for mutations?