Add catch for exceptions coming out of IfcbBinDataset #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srstsavage
added a commit
to axiom-data-science/ifcb-classifier-wrapper
that referenced
this pull request
May 26, 2024
Pin ifcb_classifier to commit 3b7f7de210438e1f3a7b451ed51ad6374099e8e9 so we don't get unexpected changes from upsteam. Also change to using Trevor's method of catching and logging IfcbBinDataset loading errors (better because it adds to error_bins for display at the end of the run). Waiting for his fix to be merged into upstream here: WHOIGit/ifcb_classifier#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I ended up having issues running this in production against large numbers of bins in cases where
IfcbBinDatasetfails to parse the bin fileset. I'm still not quite sure why exactly it's failing (still need to investigate), but these occasional failures throw uncaught exceptions that cause the whole job to die, rather than just the bad bin. I fixed it for myself by adding a catch, and appending any errors toerror_bins, a pattern I saw you using elsewhere. This has been running in production for us for several months and I haven't run into any other problems.Hopefully this fix can be of use to others as well. Let me know if you have any questions or suggestions!