slot_map: Do not require Container to provide reverse_iterator typedefs. #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attn: @Masstronaut
With this patch,
slot_map<T,K,C>
will propagate the "reverse-iterability" ofC<T>
, both the existence of the member typedefs and the existence of the member functionsrbegin
,rend
,crbegin
, andcrend
(as a group, not individually).Is this desirable? I tend to think yes, because implementing reverse-iterability for a custom container is usually wasted busywork. OTOH, it could alternatively be addressed by some library (either SG14 or Boost or otherwise) providing a
reversible
mix-in:BTW, the fact that this
reVector
alias template can be passed to a template template parameter is very cool. I was worried that it wasn't going to be that easy.