Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial configuration for COUNTRY=bhutan #1236

Merged
merged 5 commits into from
May 7, 2024
Merged

Conversation

wadhwamatic
Copy link
Member

Description

This fixes #issueNumber.

How to test the feature:

  • [ ]
  • [ ]

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

Copy link

github-actions bot commented May 5, 2024

Build succeeded and deployed at https://prism-1236.surge.sh
(hash 1a85c00 deployed at 2024-05-07T16:01:59)

@ericboucher ericboucher changed the title initial configuration for prism bhutan; COUNTRY=bhutan Initial configuration for COUNTRY=bhutan May 5, 2024
}
}
},
"rainfall_dekad": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rely on the shared config as much as possible here.
If we are hindered by admin areas/boundaries, let's make a note of it in #1212

Copy link
Member Author

@wadhwamatic wadhwamatic May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericboucher - I added a comment in 1212 as suggested. I could add chart_data to shared/layers.json but the levels fields will be wrong. Should we add it anyway, or just skip that element in the shared config, knowing either will break the chart feature unless the local config addresses it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep it as you did for now I think, it's clearer

"alertFormActive": false,
"hidePanel": false,
"enableNavigationDropdown": true,
"icons": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, let's rely on the shared config as much as possible for things like that. Don't hesitate to add to the shared/prism.json

@wadhwamatic wadhwamatic merged commit a0e306e into master May 7, 2024
6 checks passed
@wadhwamatic wadhwamatic deleted the btn-init-config branch May 7, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants