-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial configuration for COUNTRY=bhutan #1236
Conversation
Build succeeded and deployed at https://prism-1236.surge.sh |
} | ||
} | ||
}, | ||
"rainfall_dekad": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rely on the shared config as much as possible here.
If we are hindered by admin areas/boundaries, let's make a note of it in #1212
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericboucher - I added a comment in 1212 as suggested. I could add chart_data
to shared/layers.json
but the levels
fields will be wrong. Should we add it anyway, or just skip that element in the shared config, knowing either will break the chart feature unless the local config addresses it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep it as you did for now I think, it's clearer
"alertFormActive": false, | ||
"hidePanel": false, | ||
"enableNavigationDropdown": true, | ||
"icons": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, let's rely on the shared config as much as possible for things like that. Don't hesitate to add to the shared/prism.json
Description
This fixes #issueNumber.
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn start
REACT_APP_COUNTRY=cambodia yarn start
REACT_APP_COUNTRY=mozambique yarn start
Screenshot/video of feature: