-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Augment country mask quality and bypass complex boundaries #1132
base: master
Are you sure you want to change the base?
Conversation
Build succeeded and deployed at https://prism-1132.surge.sh |
@ericboucher - we can get admin0 files and add them during the config process going forward. Generally, the most reliable source is HDX, ideally datasets tagged with 'COD'. The format is usually going to be a shapefile. I'll add Mozambique to this PR and revisit others soon. |
This reverts commit 3643d5b.
Hmmm. When I added an admin0 boundary for Mozambique using the HDX data, the stripe returns. The issue with using the boundary you included @ericboucher is that they are not fully aligned with the other admin boundaries, and since this is for a print feature, fidelity matters. We shouldn't see boundaries like this: |
@ericboucher - the last moz boundary file I tried seems to work well. File size went up, but it's still under 2mb. Here's what I did in QGIS:
|
Description
This fixes two issues we were seeing with the mask feature of the print module.
'cambodia'
'ecuador'
'indonesia'
'mozambique'
'myanmar'
'sierraleone'
How to test the feature:
Checklist - did you ...
Test your changes with
REACT_APP_COUNTRY=rbd yarn start
REACT_APP_COUNTRY=cambodia yarn start
REACT_APP_COUNTRY=mozambique yarn start
Screenshot/video of feature: