Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v5.0 #25

Closed
wants to merge 7 commits into from
Closed

Release/v5.0 #25

wants to merge 7 commits into from

Conversation

AlexGherardelli
Copy link
Collaborator

No description provided.

Copy link
Member

@paololucchino paololucchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexGherardelli, looks good! Just two small comments to look at before merging.

@@ -0,0 +1,7067 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any reasons why maybe we would prefer to not include the swagger flie

@@ -53,19 +53,21 @@ Please follow the [installation procedure](#installation--usage) and then run th

import data_bridges_client
from data_bridges_client.rest import ApiException
from data_bridges_client.token import
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think WfpApiToken is missing here?

@AlexGherardelli AlexGherardelli deleted the release/v5.0 branch September 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants