Data bridges client 4.1.0 + wrapper #21
Conversation
AlexGherardelli
commented
May 22, 2024
•
AlexGherardelli
commented
- Updated data-bridges-client to v4.1.0
- Created wrapper to simplify loading data into Python and STATA
- Created example files for wrapper
- Updated setup.py to include new dependencies
- Updated README to include usage of wrapper
…_code_refactoring
…ataBridgesAPI into major_code_refactoring
Major code refactoring
- added MIT license as agreed with RAM senior management
Create LICENSE.txt
Create mit license
Auto-generated data_bridges_client, with WFP token refresh workflow
Data Bridges client 2.0.0
… into dev-wrapper
There was a problem hiding this comment.
Hi @AlexGherardelli and @ValerioGiuffrida, thanks a lot for implementing these features. They are very valuable to make the connection to DataBridges more user-friendly.
I have one substantial design comment that we should consider. At the moment, it seems we are aiming to have one single big package with all the functionality. This can cause some issues: 1) every time we autogenerate the base client package we will need to make sure we are not messing up the other files, 2) users who just want to use the base package will need to install all the dependencies (including STATA).
I would suggest we wrap the utils package around the base one. ie we would have:
- base autogenerate python client as a standalone package
- utils package that provides helpful wrapper functions and has the base package as a dependency, in two forms:
- python only
- an extension that adds the STATA functionality (allowing users who don't need STATA to not install it.
These packages could all live in this repo, in different folders.
What do you think?
cc @delcoker
