Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: permanent weeklies list #441

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

drnlm
Copy link
Contributor

@drnlm drnlm commented Jan 18, 2024

This fixes a bug in the initial list of permanent weeklies (entries for 'Mission Complete' and 'Not a Warning Shot' were swapped) and adds a list of entries o handle the appended numbers DE added to the permanent weeklies:
missioncomplete4
missioncomplete8

My choice of 30 weeks is somewhat arbitrary, but it is enough to cover the all the "Nora's Mix" Nightwaves, based on the dates from the wiki.

Copy link

codeclimate bot commented Jan 18, 2024

Code Climate has analyzed commit 245dda4 and detected 0 issues on this pull request.

View more on Code Climate.

@TobiTenno
Copy link
Member

hi, @drnlm if you're going to continue submitting PRs, please use the correct titles so i don't have to fix it every time.

the title should be: feat: permanent weeklies list

@TobiTenno TobiTenno changed the title Feature/permanent weeklies list feat: permanent weeklies list Jan 18, 2024
@TobiTenno TobiTenno enabled auto-merge (squash) January 18, 2024 14:19
@TobiTenno TobiTenno merged commit cdebd82 into WFCD:master Jan 18, 2024
8 checks passed
@wfcd-bot-boi
Copy link
Contributor

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@drnlm drnlm deleted the feature/permanent_weeklies_list branch January 18, 2024 14:26
@drnlm
Copy link
Contributor Author

drnlm commented Jan 18, 2024

hi, @drnlm if you're going to continue submitting PRs, please use the correct titles so i don't have to fix it every time.

the title should be: feat: permanent weeklies list

Could you point me to the relevant documentation for this convention? Because I don't see this mentioned anywhere in the repo or the WFCD parent project.

Thanks

@TobiTenno
Copy link
Member

https://www.conventionalcommits.org/en/v1.0.0/

it's pretty easy to see in the commit history how we do our commit messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants