-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): bump max_old_space_size
from 4096
to 8192
MB
#672
Conversation
WalkthroughThe pull request introduces a memory allocation adjustment for Node.js processes across GitHub workflow configurations. Specifically, the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)index.d.ts (1)
The addition of 'Höllvania' to the Let's verify the usage of this new system name: ✅ Verification successfulNo issues found with adding 'Höllvania' to the SystemName type The new system name 'Höllvania' appears to be a completely new addition with no existing usage or conflicts in the codebase. The search results show no prior occurrences of this name or similar variants, indicating this is a clean addition that won't cause any compatibility issues. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any existing usage of the new system name
# and verify that it doesn't conflict with existing systems
# Search for any current usage of Höllvania
echo "Checking for current usage of Höllvania:"
rg -i "höllvania" --type json --type typescript
# Check for any potential system name conflicts
echo "Checking for similar system names to avoid confusion:"
rg -i "hollvania|holl|vania" --type json --type typescript
Length of output: 396 Script: #!/bin/bash
# Let's try a different approach without specifying file types
# First, let's find all TypeScript and JSON files
echo "Finding TypeScript and JSON files:"
fd "\.(ts|json)$"
# Then search for the system name in these files
echo -e "\nChecking for current usage of Höllvania:"
fd "\.(ts|json)$" --exec rg -i "höllvania" {} || true
echo -e "\nChecking for similar system names:"
fd "\.(ts|json)$" --exec rg -i "hollvania|holl|vania" {} || true
Length of output: 66667 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 This PR is included in version 1.1265.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What did you fix?
Bump the max memory size of V8's old memory section from
4096
to8192
megabytesReproduction steps
Evidence/screenshot/link to line
Considerations
Summary by CodeRabbit
'Höllvania'
to theSystemName
type in thewarframe-items
module.