Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/inventory equipment detection #209

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Berndy
Copy link

@Berndy Berndy commented Oct 29, 2021

What did you fix? (provide a description or issue closes statement)

  • Refactored SnapIt process
  • Improved when and how regex operations are applied => slightly improved accuracy of levenstein proximity
  • Introduced threshold for levenstein proximity (arbitrary greater than 3, however any greater than 4 could ignore "prime" substring)
  • Added detection for equipment with level from inventory
  • Overlay now displaying "owned Lvl.XX [parts_owned/parts_required]" instead of the checkmarked when owned/mastered

Notes

  • There should be another pass over naming and structure/location of the split off functionalities
  • No overlay yet for detected equipment
  • could make better display when an equipment is not owned yet
  • change display for inventory overlay to display [parts_owned/parts_required] as well to unify and save space

Considerations

  • Does this contain a new dependency? [No]
  • Does this introduce opinionated data formatting or manual data entry? [Yes]
  • Does this pr include updated data files in a separate commit that can be reverted for a clean code-only pr? [No]
  • Have I run the linter? [No]
  • Is is a bug fix, feature request, or enhancement? [Feature]

@Berndy Berndy marked this pull request as draft October 29, 2021 13:38
@PeterJeff
Copy link
Contributor

PeterJeff commented Jan 29, 2023

I tried to resolve conflicts with this PR so I could run it but I may have to manually extract the changes and smash them on top of the commit chain (so the contribution will still be there, but I will be overwriting the changes after the fact with "current" layout) instead of the result of the merge conflict resolution since the systems have changed so much since then.

I'll try a rebase first but likely will have similar luck as the initial merge conflict attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants