Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7차 세미나 구현 및 이미지 업로드 구현 #5

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Gyuminn
Copy link
Member

@Gyuminn Gyuminn commented Dec 17, 2021

📌 내용

기본 과제를 구현하였습니다!

기본과제

  • 7차 세미나 구현
  • 이미지 업로드 미리보기 구현

📌 PR Point

  • ~부분 이렇게 구현했는데, 잘 한 것인지 모르겠습니다. 봐주시면 감사하겠습니다.

📌 스크린샷

ezgif com-gif-maker

@Gyuminn Gyuminn requested review from sohee-K and younyikim December 17, 2021 07:07
@Gyuminn Gyuminn self-assigned this Dec 17, 2021
Copy link
Member

@SeojinSeojin SeojinSeojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 남기고 갑니다 총총,,
마지막까지 넘 고생많았어!!!!

import React from "react";
import styled from "styled-components";

const ImagWrapper = ({ ratio, children }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imag나 Img 둘중 하나로 통일하면 편할 듯 합니닷!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visual Studio Code에서는 변수 선택하고 F2 누르면 파일 곳곳에 있는 변수 이름들을 한방에 바꿀 수 있어요~

setArticleData(tempArticleData);
};

const handleImageChange = async (e) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PublishScreen/PublishLeftScreen.jsx에 있는 함수랑 내용과 기능이 같네요!!
이 부분을 따로 뺀 뒤 import해서 사용해도 좋을 것 같아요!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants