Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added three more relevant CiTO intention types #2520

Closed
wants to merge 1 commit into from

Conversation

egonw
Copy link
Collaborator

@egonw egonw commented Jun 22, 2024

Description

Currently, the data table of an article has rows for "reuse" and "disagreement". But not all CiTO intention types were included (because they did not exist at the time when the current query was written).

Caveats

This could make the query a bit more slow.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

Testing

The following page before the patch does not show a "disagreement" but after it should:

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@fnielsen
Copy link
Collaborator

fnielsen commented Sep 5, 2024

@fnielsen
Copy link
Collaborator

fnielsen commented Sep 5, 2024

This is running: https://scholia.toolforge.org/work/Q87908797#cito-incoming

(I do not understand why this is automagically closed)

@fnielsen fnielsen closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants