-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2429 config module #2515
Fix #2429 config module #2515
Conversation
The setup and reading of the configuration is handle by a separate module.
Okay, I think I see what you meant now. My first test did not work, but that's because the |
Example
|
@@ -218,6 +217,14 @@ function sparqlToResponse(sparql, doneCallback) { | |||
} | |||
|
|||
|
|||
function sparqlToResponse(sparql, doneCallback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying to understand this. As far as I can determine you do not have polymorphic functions in Javascript, so the second definition of sparqlToResponse
will overwrite the first one? Or what am I missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ node -e "function f(a, b) { console.log('two arguments'); } function f(a) { console.log('one argument'); } f(1, 2);"
one argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fnielsen, good catch. Are you okay to name the new one sparqlToResponse2
? If not, what name should it be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Patch pushed: 4f593ae
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fnielsen, what do you think?
Okay, we have to start moving. We have less than 6 months left.
|
Oh, I did write up how to use this patch, but forgot to add the link here: https://chem-bla-ics.linkedchemistry.info/2024/08/23/scholia.html |
The setup and reading of the configuration is handle by a separate module.
Fixes #2429
Description
The setup and reading of the configuration is handle by a separate module.
Caveats
If you make changes to the Python code
Testing
Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.
Checklist