Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add co-occurring WikiProject panel #2292

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

carlinmack
Copy link
Collaborator

Daniel mentioned that it would be useful to see co-occurring WikiProjects like we do with co-occurring topics on the topics aspect

Description

Please include a summary of the change, relevant motivation and context. If possible and applicable, include before and after screenshots and a URL where the changes can be seen.

WikiProject Invasion Biology

image

WikiProject Covid-19

image

WikiProject Film

image

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@@ -6,6 +6,7 @@

{{ sparql_to_table("maintained") }}
{{ sparql_to_table("focus") }}
{{ sparql_to_table('co-occurring') }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This id does not correspond to the id in the HTML tag.

fnielsen added a commit that referenced this pull request Jul 3, 2023
fnielsen added a commit that referenced this pull request Jul 3, 2023
@fnielsen fnielsen mentioned this pull request Jul 3, 2023
10 tasks
@fnielsen fnielsen merged commit 3eb0170 into WDscholia:master Jul 3, 2023
@fnielsen
Copy link
Collaborator

fnielsen commented Jul 3, 2023

@fnielsen
Copy link
Collaborator

fnielsen commented Jul 3, 2023

I changed the filename back to what you originally had. Would this not be the most "natural"?

@carlinmack
Copy link
Collaborator Author

@fnielsen
Copy link
Collaborator

fnielsen commented Jul 3, 2023

Ok. I see. I do not know whether we should change it then. Currently it fits with the headline, but there is inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants