Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed FILTER EXISTS clause #2209

Closed

Conversation

Daniel-Mietchen
Copy link
Member

Fixes #2208

Description

Removed the FILTER EXISTS clause from
organization_page-production.sparql

Caveats

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Screenshots

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@egonw egonw added the max-5-lines Tag for pull requests to indicate the changes are at most 5 lines changed label Dec 29, 2022
@egonw egonw self-assigned this Dec 29, 2022
@egonw egonw self-requested a review December 29, 2022 14:37
Copy link
Collaborator

@egonw egonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have a hard time comparing the before/after, but the after looks fine and the before times out (for https://scholia.toolforge.org/organization/Q19845644#page-production).

But since it's via researchers that we know which works go with the institute and my limited understand of SPARQL, this also makes sense.

@egonw egonw assigned fnielsen and unassigned egonw Dec 29, 2022
@fnielsen
Copy link
Collaborator

I think there will be a double count if there are subunits, e.g., https://www.wikidata.org/wiki/Q20895241 for https://www.wikidata.org/wiki/Q1137652 vs. https://www.wikidata.org/wiki/Q19845644

@fnielsen
Copy link
Collaborator

There shouldn't be this discrepancy:

https://w.wiki/6PCA : 2022 | 5.30526315789473684211 | Egon Willighagen

https://w.wiki/6PCC : 2022 | 10.61052631578947368421 | Egon Willighagen

Perhaps a version with WITH is better.

@fnielsen
Copy link
Collaborator

Probably superceeded with #2545

@fnielsen fnielsen closed this Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
max-5-lines Tag for pull requests to indicate the changes are at most 5 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the FILTER EXISTS from organization_page-production.sparql
3 participants