Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize remaining sparql queries in iframes #1284 #1517

Merged

Conversation

curibe
Copy link
Collaborator

@curibe curibe commented Jul 15, 2021

related to #1284, #1283, #1282, #785

Externalize the remaining sparql queries inside an iframe

This PR ends with the externalization of sparql queries.

The following files have sparql url queries inside the iframes

  • author.html ❗ It has commented iframes
  • authors.html
  • award_empty.html
  • country.html ❗ It has a commented iframe
  • property.html
  • use.html
  • venues.html
  • work_cito.html
  • works.html

Note

  • Commits with word iframe correspond to the modifications made in this PR

@curibe curibe force-pushed the externalize-remaining-sparql-iframe branch from 3f3c388 to 02dfb67 Compare July 16, 2021 22:24
curibe added 28 commits July 28, 2021 12:24
A new js function and macro was created for topics-works-matrix in author.
A new js function and macro was created for pathwat viewer
A new js function and macro was created for 404_chemical. The query require to short the inchikey
@curibe curibe force-pushed the externalize-remaining-sparql-iframe branch from 02dfb67 to ac38db3 Compare July 28, 2021 19:12
@curibe curibe force-pushed the externalize-remaining-sparql-iframe branch from ac38db3 to 5477bdb Compare July 28, 2021 20:05
@fnielsen fnielsen merged commit 2274fb9 into WDscholia:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants